563 remove n2t binder queue related #724
Merged
Merged
Conversation
Remove noid_egg library and dependencies Remove proc-binder job Remove n2t diag-identifier tool
Merge develop to main for reducing link-checker-update default pagesize to 10,000
Remove duplicated ezid client util scripts Rename misleading variables Add script to test ezid client
sfisher
approved these changes
Sep 10, 2024
Contributor
There was a problem hiding this comment.
This looks fine to me. I think it's nice you changed the SERVER variable for other things to use rather than leaving the binder stuff in there.
I don't have a ton of background on the binder queue or n2t or eggnog and all that stuff, but this seems fine to be as long as everything still works.
But I read over the code and I don't see any obvious problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sfisher This is to remove n2t binder related code from EZID:
proc-binder.pyscript which was used to manage requests in the binder queuePlease review and let me know if you have questions.
Thank you
Jing