Conversation
…s under mobile and also pops up in a position where it doesn't cut off and can be seen and used.
Contributor
|
@sfisher Hi Scott, can you put the code on Dev or Stage so we can test. |
jsjiang
approved these changes
Aug 27, 2025
Contributor
jsjiang
left a comment
There was a problem hiding this comment.
Tested v3.3.15-accessability on stage https://ezid-stg.cdlib.org/ from desktop and iPhone. Login/Logout button showed properly. Functional and UI tests also looked good.
Thank you Scott for fixing this bug.
Jing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also had to update the way I installed npm and ran gulp so I'll also update the doc repository to explain how to do this.
I had to remove the screen media types from the login button so it always appears. Also had to move the code for the login form popup outside the header nav so that it doesn't get messed with when screen sizes make that area too small to display what is needed.
Javascript finds the position of the button on the page and makes it appear in an appropriate place under the button so it doesn't get cut off or go off the left or right edge or in some weird unaligned position.