Issue #1258 #1261
Merged
Issue #1258 #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enerate strings that could not be converted back to the original enumeration value.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1261 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 17 19 +2
Lines 4546 5040 +494
Branches 0 1077 +1077
===========================================
+ Hits 4546 5040 +494 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix an issue where an enumeration with a stream output method would generate strings that could not be converted back to the original enumeration value.
Fixes Issue #1258
recent changes fixed a few issues with the default_val method. The method used the to_string, which in cases where a user supplied a streaming operation to enumerations they could not be converted back to the enumeration properly resulting in some errors and confusing help output.