Fix 'UTF-8 config filenames not supported on Windows' #912#1273
Conversation
|
We are either going to have to put the change inside a conditional compilation block or define |
|
I've added a conditional compilation block. I think the fix should cover many users. However, since the --config path is stored as a std::string, it must be encoded in UTF-8. I assume that, even on older C++ standards, the to_path function on Windows should convert from UTF-8 to the current locale or directly to UTF-16 (the overload for the std::ifstream constructor that takes a wide string is non-standard though.) |
|
@all-contributors add @The0Dev for code |
|
I've put up a pull request to add @The0Dev! 🎉 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1273 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 17 19 +2
Lines 4546 5050 +504
Branches 0 1080 +1080
===========================================
+ Hits 4546 5050 +504 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds @The0Dev as a contributor for code. This was requested by phlptp [in this comment](#1273 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
This PR should fix #912