Fix build rules for Bazel 9#1287
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1287 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 17 19 +2
Lines 4546 5070 +524
Branches 0 1087 +1087
===========================================
+ Hits 4546 5070 +524 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@all-contributors add @mikael-s-persson for platform,infra |
|
I've put up a pull request to add @mikael-s-persson! 🎉 |
|
Thank you, I had made a few fixes in one of the other branches for testing but I like this better |
|
Thanks! You might consider a new release and update the central registry (https://registry.bazel.build/modules/cli11). |
Adds @mikael-s-persson as a contributor for platform, infra. This was requested by phlptp [in this comment](#1287 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
|
I am hoping to resolve the module issues and potentially a few others then get another release out soon. |
|
@phlptp I saw the new version and tested it out on some repos with bazel 9, so I created a PR for a new BCR entry: bazelbuild/bazel-central-registry#7884 |
Fix build rules for Bazel 9
The cc_* rules have to be loaded explicitly from rules_cc now. I tested down to version 7.4.0 and added compatibility constraint (I also checked on main branch, it only works for version >= 7.4.0 too).