Skip to content

fix: fixed footer newline behavior#796

Merged
henryiii merged 3 commits into
CLIUtils:mainfrom
polistern:fix/footer-newline
Oct 29, 2022
Merged

fix: fixed footer newline behavior#796
henryiii merged 3 commits into
CLIUtils:mainfrom
polistern:fix/footer-newline

Conversation

@polistern
Copy link
Copy Markdown
Contributor

@polistern polistern commented Oct 28, 2022 •
edited
Loading

Footer newline behavior

Without or empty footer now:

app v1
use: [-h|--help] | --option UINT

Options:
  -h,--help                             Show this message
<newline>

With footer now:

app v1
use: [-h|--help] | --option UINT

Options:
  -h,--help                             Show this message
<newline>
footer

Without or empty footer with follow changes:

app v1
use: [-h|--help] | --option UINT

Options:
  -h,--help                             Show this message

With footer (like now):

app v1
use: [-h|--help] | --option UINT

Options:
  -h,--help                             Show this message
<newline>
footer

If footer is set, then we can expect it to be at least one string.
So somebody can add more newlines directly in footer string if needed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 28, 2022 •
edited
Loading

Codecov Report

Base: 99.42% // Head: 99.42% // No change to project coverage 👍

Coverage data is based on head (6bc52ed) compared to base (25274e2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #796   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          16       16           
  Lines        3977     3977           
=======================================
  Hits         3954     3954           
  Misses         23       23
Impacted Files Coverage Δ
include/CLI/impl/Formatter_inl.hpp 99.40% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@polistern polistern mentioned this pull request Oct 28, 2022
Merged
@henryiii henryiii merged commit e2270dd into CLIUtils:main Oct 29, 2022
@github-actions github-actions Bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Oct 29, 2022
@polistern polistern deleted the fix/footer-newline branch November 6, 2022 12:58
@henryiii henryiii removed needs README Needs to be mentioned in the README needs changelog Hasn't been added to the changelog yet labels Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henryiii henryiii henryiii approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polistern @henryiii