Skip to content

fix some GCC warnings and update codecov#813

Merged
henryiii merged 12 commits into
CLIUtils:mainfrom
phlptp:warnfix_coverage
Dec 10, 2022
Merged

fix some GCC warnings and update codecov#813
henryiii merged 12 commits into
CLIUtils:mainfrom
phlptp:warnfix_coverage

Conversation

@phlptp
Copy link
Copy Markdown
Collaborator

@phlptp phlptp commented Dec 7, 2022

Try to address some of the warnings that have been reported from GCC.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 7, 2022 •
edited
Loading

Codecov Report

Base: 99.42% // Head: 99.44% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (02cc628) compared to base (71755e4).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
+ Coverage   99.42%   99.44%   +0.01%     
==========================================
  Files          16       16              
  Lines        3991     3950      -41     
==========================================
- Hits         3968     3928      -40     
+ Misses         23       22       -1
Impacted Files Coverage Δ
include/CLI/App.hpp 100.00% <ø> (ø)
include/CLI/Validators.hpp 99.30% <0.00%> (-0.70%) ⬇️
include/CLI/impl/StringTools_inl.hpp 95.42% <0.00%> (-0.09%) ⬇️
include/CLI/impl/Validators_inl.hpp 99.50% <0.00%> (-0.02%) ⬇️
include/CLI/impl/Option_inl.hpp 99.74% <0.00%> (-0.01%) ⬇️
include/CLI/Error.hpp 100.00% <0.00%> (ø)
include/CLI/Timer.hpp 100.00% <0.00%> (ø)
include/CLI/Option.hpp 100.00% <0.00%> (ø)
include/CLI/ConfigFwd.hpp 100.00% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phlptp
Copy link
Copy Markdown
Collaborator Author

phlptp commented Dec 7, 2022

Fixes the redundant declaration warnings from #805

@phlptp phlptp mentioned this pull request Dec 7, 2022
Closed
@phlptp phlptp force-pushed the warnfix_coverage branch 2 times, most recently from d1dc4ec to 79f89f4 Compare December 7, 2022 18:01
@phlptp phlptp requested a review from henryiii December 7, 2022 22:52
@phlptp phlptp changed the title DRAFT: add some warning for GCC output fix some GCC warnings and update codecov Dec 7, 2022
@phlptp phlptp mentioned this pull request Dec 10, 2022
Merged
@henryiii henryiii merged commit 75b19db into CLIUtils:main Dec 10, 2022
@henryiii henryiii deleted the warnfix_coverage branch December 10, 2022 15:30
@github-actions github-actions Bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Dec 10, 2022
@phlptp phlptp mentioned this pull request Dec 10, 2022
Closed
@henryiii henryiii removed the needs README Needs to be mentioned in the README label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henryiii henryiii henryiii approved these changes

Assignees

No one assigned

Labels

needs changelog Hasn't been added to the changelog yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phlptp @henryiii