Skip to content

environment variables and subcommands#904

Merged
phlptp merged 2 commits into
CLIUtils:mainfrom
phlptp:bugfix_903
Jul 9, 2023
Merged

environment variables and subcommands#904
phlptp merged 2 commits into
CLIUtils:mainfrom
phlptp:bugfix_903

Conversation

@phlptp
Copy link
Copy Markdown
Collaborator

@phlptp phlptp commented Jul 9, 2023

Do not check environment variables if a subcommand has not been triggered.

Fixes #903

@phlptp phlptp added the bug label Jul 9, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (985a19f) 99.46% compared to head (c2ec0b9) 99.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #904   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          18       18           
  Lines        4099     4100    +1     
=======================================
+ Hits         4077     4078    +1     
  Misses         22       22           
Impacted Files Coverage Δ
include/CLI/impl/App_inl.hpp 99.31% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phlptp phlptp merged commit ff648c8 into CLIUtils:main Jul 9, 2023
@phlptp phlptp deleted the bugfix_903 branch July 9, 2023 15:46
@github-actions github-actions Bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI::Option::envname() should trigger validators only if corresponding subcommand is called

1 participant