Skip to content

Tags: CMSgov/bcda-app

Tags

r276

Toggle r276's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
BCDA-9586: Add fargate to prod (#1277)

## 🎫 Ticket

https://jira.cms.gov/browse/BCDA-9586

## 🛠 Changes

Adjusted various build and deploy related workflows to account for
fargate prod.

## ℹ️ Context

Part of the process of moving fargate to prod env.

<!-- If any of the following security implications apply, this PR must
not be merged without Stephen Walter's approval. Explain in this section
and add @SJWalter11 as a reviewer.
  - Adds a new software dependency or dependencies.
  - Modifies or invalidates one or more of our security controls.
  - Stores or transmits data that was not stored or transmitted before.
- Requires additional review of security implications for other reasons.
-->

## 🧪 Validation

Workflow testing.

Co-authored-by: Parwinder Bhagat <Parwinder.Bhagat@e14s.com>

r275

Toggle r275's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
BCDA-9583: remove caching of apk upgrade in dockerfiles (#1269)

## 🎫 Ticket

https://jira.cms.gov/browse/BCDA-9583

[related ssas PR](CMSgov/bcda-ssas-app#269)

## 🛠 Changes

<!-- What was added, updated, or removed in this PR? -->

- remove caching of `apk upgrade` in dockerfiles

## ℹ️ Context

<!-- Why were these changes made? Add background context suitable for a
non-technical audience. -->

The update/upgrade step should not be cached in order to conform with
[CMS Hybrid Cloud dockerfile
recommendations.](https://cloud.cms.gov/docker-container-security/#docker-container-scanning-and-remediation)

> When adding the update instruction, ensure that the --no-cache flag is
used during the docker build process to avoid using cached layers.
Otherwise, when you build any image later using the same instruction,
this will cause the previously cached update layer to be used,
potentially preventing any fresh updates from being applied to later
builds.

<!-- If any of the following security implications apply, this PR must
not be merged without Stephen Walter's approval. Explain in this section
and add @SJWalter11 as a reviewer.
  - Adds a new software dependency or dependencies.
  - Modifies or invalidates one or more of our security controls.
  - Stores or transmits data that was not stored or transmitted before.
- Requires additional review of security implications for other reasons.
-->

## 🧪 Validation

<!-- How were the changes verified? Did you fully test the acceptance
criteria in the ticket? Provide reproducible testing instructions and
screenshots if applicable. -->

Tested locally

---------

Co-authored-by: Parwinder Bhagat <Parwinder.Bhagat@e14s.com>

r274

Toggle r274's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
BCDA-9598: remove deprecated params from sops (#1267)

## 🎫 Ticket

https://jira.cms.gov/browse/BCDA-9598

## 🛠 Changes

<!-- What was added, updated, or removed in this PR? -->

- remove parameter store params related to the old queue database 

## ℹ️ Context

<!-- Why were these changes made? Add background context suitable for a
non-technical audience. -->

Deprecated params are being removed as part of a paramstore cleanup.
These params have already been removed from paramstore from all
environments.

<!-- If any of the following security implications apply, this PR must
not be merged without Stephen Walter's approval. Explain in this section
and add @SJWalter11 as a reviewer.
  - Adds a new software dependency or dependencies.
  - Modifies or invalidates one or more of our security controls.
  - Stores or transmits data that was not stored or transmitted before.
- Requires additional review of security implications for other reasons.
-->

## 🧪 Validation

<!-- How were the changes verified? Did you fully test the acceptance
criteria in the ticket? Provide reproducible testing instructions and
screenshots if applicable. -->

N/A

r273

Toggle r273's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
SOPS: remove unneeded vars (#1263)

## 🎫 Ticket

n/a

## 🛠 Changes

- removed `BB_CLIENT_CA_08282023` env var

## ℹ️ Context

Certificate is not used, general cleanup.

<!-- If any of the following security implications apply, this PR must
not be merged without Stephen Walter's approval. Explain in this section
and add @SJWalter11 as a reviewer.
  - Adds a new software dependency or dependencies.
  - Modifies or invalidates one or more of our security controls.
  - Stores or transmits data that was not stored or transmitted before.
- Requires additional review of security implications for other reasons.
-->

## 🧪 Validation

n/a

r272

Toggle r272's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
BCDA-9573: update smoke tests (#1244)

## 🎫 Ticket

https://jira.cms.gov/browse/BCDA-9573

## 🛠 Changes

- remove all steps except postman tests and retrieving env variables.

## ℹ️ Context

make docker-bootstrap and other related setup work is running before our
smoke tests but aren't necessary; tests are configured within postman
docker image and shouldn't rely on other local containers to run.

current smoke test suite takes about 9-12 minutes to run and these
changes will reduce that to 2-3 minutes.

<!-- If any of the following security implications apply, this PR must
not be merged without Stephen Walter's approval. Explain in this section
and add @SJWalter11 as a reviewer.
  - Adds a new software dependency or dependencies.
  - Modifies or invalidates one or more of our security controls.
  - Stores or transmits data that was not stored or transmitted before.
- Requires additional review of security implications for other reasons.
-->

## 🧪 Validation

Smoke tests are passing except for PACA tests, which have known
flakiness: https://github.com/CMSgov/bcda-app/actions/runs/19083663830

r271

Toggle r271's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
BCDA-9362: speed up loading test data (#1229)

## 🎫 Ticket

https://jira.cms.gov/browse/BCDA-9362

## 🛠 Changes

<!-- What was added, updated, or removed in this PR? -->
Run a docker container once and exec into it to run scripts instead of
booting multiple containers one after another

## ℹ️ Context

<!-- Why were these changes made? Add background context suitable for a
non-technical audience. -->

The previous PR in the repo for this ticket slowed down an already-slow
`make docker-bootstrap`
This PR speeds it up to be much faster than even before the previous PR
by booting the API container once and exec-ing into it to perform data
seeding instead of booting api containers one after another.
This may also prevent all or most of the many orphan containers that
`make docker-bootstrap` previously created.

<!-- If any of the following security implications apply, this PR must
not be merged without Stephen Walter's approval. Explain in this section
and add @SJWalter11 as a reviewer.
  - Adds a new software dependency or dependencies.
  - Modifies or invalidates one or more of our security controls.
  - Stores or transmits data that was not stored or transmitted before.
- Requires additional review of security implications for other reasons.
-->

## 🧪 Validation

<!-- How were the changes verified? Did you fully test the acceptance
criteria in the ticket? Provide reproducible testing instructions and
screenshots if applicable. -->

r270

Toggle r270's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
BCDA-9462: update bfd server path (#1220)

## 🎫 Ticket

https://jira.cms.gov/browse/BCDA-9462

## 🛠 Changes

Updated the path to the BFD server for local development

## ℹ️ Context

<!-- Why were these changes made? Add background context suitable for a
non-technical audience. -->

As part of the investigation into BCDA-9462, it was discovered that the
path to the bfd test server for local development needed to be updated.

<!-- If any of the following security implications apply, this PR must
not be merged without Stephen Walter's approval. Explain in this section
and add @SJWalter11 as a reviewer.
  - Adds a new software dependency or dependencies.
  - Modifies or invalidates one or more of our security controls.
  - Stores or transmits data that was not stored or transmitted before.
- Requires additional review of security implications for other reasons.
-->

## 🧪 Validation

<!-- How were the changes verified? Did you fully test the acceptance
criteria in the ticket? Provide reproducible testing instructions and
screenshots if applicable. -->

Run the smoke tests via `make smoke-test env=local maintenanceMode=""`
and observe that the tests can reach the "Get __ export job data" steps
and pass.

r269

Toggle r269's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
[PLT-1340] Convert terraform to opentofu (#1212)

## 🎫 Ticket

https://jira.cms.gov/browse/PLT-1340

## 🛠 Changes

Removed terraform commands.  Added opentofu commands. 

## ℹ️ Context

To standardize on Opentofu.

## 🧪 Validation

Validated by running the bcda-app Deploy-All workflow:
https://github.com/CMSgov/bcda-app/actions/runs/17980953023/job/51146587684

---------

Co-authored-by: Sean Fern <seanfern@navapbc.com>

r268

Toggle r268's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
BCDA-9366: Add nil response handling to BFD requests (#1206)

## 🎫 Ticket

https://jira.cms.gov/browse/BCDA-9366

## 🛠 Changes

Add error handling for nil response from BFD.

## ℹ️ Context

A nil response from BFD was breaking the resp.Body portion of the error
check. This was then crashing the server and obfuscating any relevant,
helpful logs. This should resolve that situation.

<!-- If any of the following security implications apply, this PR must
not be merged without Stephen Walter's approval. Explain in this section
and add @SJWalter11 as a reviewer.
  - Adds a new software dependency or dependencies.
  - Modifies or invalidates one or more of our security controls.
  - Stores or transmits data that was not stored or transmitted before.
- Requires additional review of security implications for other reasons.
-->

## 🧪 Validation

Local testing and linting.

r267

Toggle r267's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
BCDA-9377: Remove init from main.go for api and worker (#1200)

## 🎫 Ticket

https://jira.cms.gov/browse/BCDA-9377

## 🛠 Changes

- removed init from `bcda/main.go` and `bcdaworker/main.go`.
- added directory setup to `bcdaworker/main_test.go`

## ℹ️ Context

Part of ongoing effort to remove init to improve test suite.


<!-- If any of the following security implications apply, this PR must
not be merged without Stephen Walter's approval. Explain in this section
and add @SJWalter11 as a reviewer.
  - Adds a new software dependency or dependencies.
  - Modifies or invalidates one or more of our security controls.
  - Stores or transmits data that was not stored or transmitted before.
- Requires additional review of security implications for other reasons.
-->

## 🧪 Validation

Tests passing.