Binary projects: Fall back to an xcframework when nothing else is available #3194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firebase 8.x is xcframework-only. We actually can't change the test to
look for an xcframework:
[ -d Carthage/Build/iOS/FirebaseAnalytics.framework ]
because xcframework lookup requires the system to have knowledge of the
`com.apple.xcframework` UTI, and it's only going to have that if it
has Xcode 11+ installed, which our 10.1 CI machines do not.
08bd602 to
978f215
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic introduced in #3152 attempts to avoid downloading an xcframework when a user didn't ask for one. This is acceptable for GitHub Releases, where a source fallback is available, but not for xcframework-only binary projects. Projects which only advertise an XCFramework appear to succeed but download nothing when built without
--use-xcframeworks:(Notice that there's no
*** Downloading Foo binary at "x.y.z"event indicating that an actual binary was downloaded.)Fixed by causing binaryAssetFilter to behave differently for binary project URLs, and select unwanted xcframework releases as a last resort.