Doc, changes, example and test for raising errors about CRSs #1656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 26, 2020
cartoframes/viz/source.py
Outdated
| self.query = self.manager.compute_query(source) | ||
| self.credentials = self.manager.credentials | ||
| elif isinstance(source, DataFrame): | ||
| if isinstance(source, GeoDataFrame): # Checking CRS |
There was a problem hiding this comment.
at least two spaces before inline comment
Jesus89
approved these changes
Jun 30, 2020
Member
Jesus89
left a comment
There was a problem hiding this comment.
Good job!
Note: I made some changes to make sure this works also with Geopandas 0.6.0 (not tools.CRS available).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story ch58758