Removed the batch_size parameter in the call to bulk_geocode #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-contreras-deel
approved these changes
Jul 21, 2020
Contributor
simon-contreras-deel
left a comment
There was a problem hiding this comment.
It makes sense to me. From docs:
If not specified, it defaults to the maximum size available to the user, which is typically the best option, performance-wise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
batch_sizeparameter in the call tocdb_dataservices_client.cdb_bulk_geocode_street_pointRemoved
BATCH_SIZEfromgeocoding_constants.pyhttps://app.clubhouse.io/cartoteam/story/91890/sociallydetermined-onprem-user-can-t-geocode-in-cf-due-to-batch-size-must-be-lower-than-error