Skip to content

Remove None from geometry_types to check validity #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antoniocarlon merged 2 commits into from
Sep 23, 2020
Merged

Remove None from geometry_types to check validity #1691

antoniocarlon merged 2 commits into from
Sep 23, 2020

Conversation

@antoniocarlon
Copy link
Contributor

@antoniocarlon antoniocarlon commented Sep 22, 2020

The error was:

ValueError: No valid geometry column types ({None, 'Point'}), it has to be one of the next type sets: [{'Point'}, {'MultiPoint'}, {'LineString'}, {'MultiLineString'}, {'LineString', 'MultiLineString'}, {'Polygon'}, {'MultiPolygon'}, {'MultiPolygon', 'Polygon'}].

when doing

from cartoframes.viz import Map, Layer
Map([Layer(geo_gdf)])

The workaround is pretty easy:

from cartoframes.viz import Map, Layer
Map([Layer(geo_gdf[geo_gdf.the_geom != None])])

but we can do it more straightforward by just removing the None from the set (None can be returned by the geocoder if no results are found for a given address for example).

Jesus89
Jesus89 reviewed Sep 23, 2020
View reviewed changes
Copy link
Member

@Jesus89 Jesus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the problem is with our check, it's OK to remove it in that part. I would add a unit test to cover also None values.

@antoniocarlon antoniocarlon merged commit 9c41177 into develop Sep 23, 2020
@antoniocarlon antoniocarlon deleted the feature/ch106409/ibicarto-1-no-valid-geometry-error-in-cf branch September 23, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jesus89 Jesus89 Jesus89 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antoniocarlon @Jesus89