Mmoncadaisla/formula widget count operation #1703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesus89
approved these changes
Nov 25, 2020
Member
Jesus89
left a comment
There was a problem hiding this comment.
Great thanks!
Not sure why this was added by default, but it makes sense this way.
Member
|
It will be available in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR from Support aims to fix a small bug, in which if the column to be used in a formula widget is named 'count', the aggregation performed is currently
'count'regardless of theoperation.More details here: https://app.clubhouse.io/cartoteam/story/119026/cartoframes-formula-widget-misbehavior-when-column-is-named-count
This PR contains two file modifications:
Formula widget: perform an evaluation on 'operation' parameter only
Formula widget unit tests (viewport + global): create a formula widget with
operation='count'Result after changes using
sumoperation: