Fix source generator for nullable value type argument with explicit default value #8945
+997
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Closes #bugnumber (in this specific format)
Background:
After switching from p-16.0.0-p.8.9 to p.10.1 the following results in a compile error CS0103 since the source code generator emits
Falseas the value ofHotChocolate.Types.Descriptors.Configurations.ArgumentConfiguration.RuntimeDefaultValue(instead offalse)Tests have also been added for other special cased value types.
One test was adjusted, as it is more correct yet than it was before.