1.21.x port #18
1.21.x port #18
Conversation
|
Wow... |
|
Thank you very much for working on this @Riflusso @toxicity188. Sorry for the delay, but I will be going through and reviewing this soon. I just wanted to let you know I have not ignored or forgotten about it. |
|
Okay, after some testing found critical bug with CHANNEL_VIDEO_LIST_HISTORY_SPLIT inbound that causes server disconnecting with |
|
In the end it's not a problem with the port itself, but a problem with remapping the final jar to add CEF and idk how to fix it |
|
Alright, thanks for letting me know. I should have time to get to this PR over the weekend |
| }, | ||
| b -> { | ||
| PreviewScreen previewScreen = new PreviewScreen().fromBytes(b); | ||
| VideoInfo videoInfo = b.readBoolean() ? new VideoInfo().fromBytes(b) : null; |
There was a problem hiding this comment.
We are already reading VideoInfo inside of PreviewScreen#fromBytes
https://github.com/Riflusso/CinemaMod/blob/b97cb59cd09e1a863bdaf6335b9adf7fc4046dfd/fabric/src/main/java/com/cinemamod/fabric/screen/PreviewScreen.java#L174-L175
|
I think the error |
|
Hi, can someone upload a ready-made version of the plugin in the format.jar for version 1.21.1 please, I just don't know much about java. |
Ported to 1.21.x, everything works well with 1.0.6 bukkit plugin
Fixed some setting screens rendering issues at newer versions and added more translations for flexibility
Especially thanks to @toxicity188 for new implementation of CustomPayload networking