Skip to content

Added conditions to include attributes in the payload only when they are specified by the user in the module 'aci_interface_policy_leaf_policy_group'#578

Merged
lhercot merged 1 commit into
CiscoDevNet:masterfrom
shrsr:apic12
Jan 12, 2024
Merged

Conversation

@shrsr

@shrsr shrsr commented Jan 11, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

…only when they are specified by the user in the module 'aci_interface_policy_leaf_policy_group'
@shrsr shrsr self-assigned this Jan 11, 2024
@shrsr shrsr requested review from akinross, anvitha-jain, gmicol, lhercot, sajagana and samiib and removed request for anvitha-jain and lhercot January 11, 2024 15:27
@shrsr shrsr linked an issue Jan 11, 2024 that may be closed by this pull request
@codecov

codecov Bot commented Jan 11, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (647dc30) 96.26% compared to head (cde3c2b) 35.20%.

Files Patch % Lines
.../modules/aci_interface_policy_leaf_policy_group.py 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #578       +/-   ##
===========================================
- Coverage   96.26%   35.20%   -61.06%     
===========================================
  Files         231      231               
  Lines       10647    10659       +12     
  Branches     1603     1607        +4     
===========================================
- Hits        10249     3753     -6496     
- Misses        305     6906     +6601     
+ Partials       93        0       -93     
Flag Coverage Δ
integration ?
sanity 35.20% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmicol gmicol left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross akinross left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 32197a9 into CiscoDevNet:master Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aci_interface_policy_leaf_policy_group no longer working in 2.8.0

4 participants