Skip to content

Conversation

@avalcepina
Copy link
Contributor

@avalcepina avalcepina commented Jul 9, 2025

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

=======

  • Adding rollback pipeline values to LocalPipelineValues in config/pipeline.go
  • Updating tests in 'config/pipeline_test.go'

Rationale

=========

This will allow to correctly validate configs for rollback pipelines.

@avalcepina avalcepina changed the title Adding rollback pipeline values to config validation logic [REL-4136] Adding rollback pipeline values to config validation logic Jul 9, 2025
@avalcepina avalcepina marked this pull request as ready for review July 9, 2025 13:48
@avalcepina avalcepina requested a review from a team as a code owner July 9, 2025 13:48
@avalcepina avalcepina merged commit 5921403 into main Jul 10, 2025
1 check passed
@avalcepina avalcepina deleted the REL-4136_rollback_pipeline_values branch July 10, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants