Bug fix in conditional advective_tracer_flux
#2587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchor
approved these changes
May 31, 2022
| using Oceananigans.Operators: Vᶜᶜᶜ | ||
| using Oceananigans.Fields: ZeroField | ||
|
|
||
| @inline _advective_tracer_flux_x(args...) = advective_tracer_flux_x(args...) |
Collaborator
There was a problem hiding this comment.
It seems you have cut these lines from momentum_advection_operators.jl to here, which makes a lot of sense. What was the bug that occurred before?
Member
There was a problem hiding this comment.
The bug is the difference between
_advective_tracer_flux_z(args...) = _advective_tracer_flux_z(args...)
and
_advective_tracer_flux_z(args...) = advective_tracer_flux_z(args...)
francispoulin
approved these changes
May 31, 2022
glwagner
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably doesn't really matter because of impenetrability....