Skip to content

Fix fatal interaction between FieldTimeSeries construction and input validation #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glwagner merged 4 commits into from
Jun 1, 2022
Merged

Fix fatal interaction between FieldTimeSeries construction and input validation #2589

glwagner merged 4 commits into from
Jun 1, 2022

Conversation

@glwagner
Copy link
Member

@glwagner glwagner commented May 31, 2022

Closes #2588

@glwagner glwagner requested a review from tomchor May 31, 2022 20:20
@glwagner
Copy link
Member Author

glwagner commented May 31, 2022 •
edited
Loading

I really would rather emit a warning here rather than an error because I don't think an error is appropriate when input is legitimate (which was the case for what FieldTimeSeries did, prior to this PR). @tomchor @simone-silvestri is that ok with you two?

@tomchor
Copy link
Collaborator

tomchor commented May 31, 2022

I really would rather emit a warning here rather than an error because I don't think an error is appropriate when input is legitimate (which was the case for what FieldTimeSeries did, prior to this PR). @tomchor @simone-silvestri is that ok with you two?

Sure

@glwagner glwagner merged commit d675d8b into main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomchor tomchor tomchor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Input validation for stretched grid dimensions breaks FieldTimeSeries

3 participants

@glwagner @tomchor