Fix cloud sampling failure when the density for a single object is too low#2265
Merged
dgirardeau merged 2 commits intoCloudCompare:masterfrom Dec 28, 2025
Merged
Fix cloud sampling failure when the density for a single object is too low#2265dgirardeau merged 2 commits intoCloudCompare:masterfrom
dgirardeau merged 2 commits intoCloudCompare:masterfrom
Conversation
dgirardeau
reviewed
Dec 20, 2025
|
|
||
| if (!cloud) | ||
| { | ||
| return cmd.error(QObject::tr("Cloud sampling failed!")); |
Member
There was a problem hiding this comment.
you could maybe still issue a warning?
Contributor
Author
|
I added the same error message as in the GUI |
dgirardeau
approved these changes
Dec 23, 2025
Member
dgirardeau
left a comment
There was a problem hiding this comment.
Looks good, thanks for the update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sampling points on a mesh using the CLI, the execution should not terminate when ccGenericMesh::samplePoints returns nullptr. This is specially important when an object of the mesh is too small to have its cloud generated (in this case sampledCloud->size() == 0), so the sampling of rest of the objects should continue, as it does in the GUI.