Skip to content

Conversation

@mskapusuz
Copy link
Contributor

@mskapusuz mskapusuz commented Dec 15, 2021

Summary

New locked layout added for the WooCommerce Checkout Layout Types.

Will affect visual aspect of the product

NO

Screenshots

Test instructions

  • make sure there is no regression once the free->pro upgrade. (wc checkout layouts should worked well after the pro upgrade)

Closes codeinwp/neve-pro-addon#1723.

@github-actions
Copy link

github-actions bot commented Dec 15, 2021

Plugin build for 89e0c21 is ready 🛎️!

@mskapusuz mskapusuz force-pushed the feat/checkout-locked-layout branch from ce5c85e to b641142 Compare December 15, 2021 12:36
@irinelenache
Copy link
Contributor

@mskapusuz After activating Neve pro, Vertical and Stepped layouts are not clickable anymore https://vertis.d.pr/LTFJGl
You can check the issue on this instance:

 Admin area URL: https://justifyjellyfish.tastewp.com/wp-admin 
 Username: irinel 
 Password: YW2MxvdJce0 

@mskapusuz
Copy link
Contributor Author

@irinelenache Thank you for your findings! I've fixed it just now!

@irinelenache
Copy link
Contributor

irinelenache commented Dec 22, 2021

@mskapusuz Now the layouts are clickable, thanks 🚀
One more small thing, i don't know exactly if it's an issue:

  • If i select a Neve pro checkout layout and then deactivate Neve pro plugin, the customizer setting will look like this https://vertis.d.pr/V72w7h . The active layout is the Standard one and clicking it once fixes this visual issue.

Let me know your thoughts on this 👍

@mskapusuz
Copy link
Contributor Author

@mskapusuz Now the layouts are clickable, thanks 🚀 One more small thing, i don't know exactly if it's an issue:

  • If i select a Neve pro checkout layout and then deactivate Neve pro plugin, the customizer setting will look like this https://vertis.d.pr/V72w7h . The active layout is the Standard one and clicking it once fixes this visual issue.

Let me know your thoughts on this 👍

@irinelenache I think, that's an issue, we're showing standard layout if pro is disabled. So, the standard one should be selected. I'll handle that. Thanks 🚀

@mskapusuz mskapusuz force-pushed the feat/checkout-locked-layout branch 2 times, most recently from 230ea23 to 7b8934e Compare December 22, 2021 13:09
Copy link
Contributor

@cristian-ungureanu cristian-ungureanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@mskapusuz
Copy link
Contributor Author

@mskapusuz Now the layouts are clickable, thanks 🚀 One more small thing, i don't know exactly if it's an issue:

  • If i select a Neve pro checkout layout and then deactivate Neve pro plugin, the customizer setting will look like this https://vertis.d.pr/V72w7h . The active layout is the Standard one and clicking it once fixes this visual issue.

Let me know your thoughts on this 👍

That's fixed, thank you! @irinelenache

@irinelenache
Copy link
Contributor

@mskapusuz Tested again and now everything works fine, thanks 🚀

@abaicus abaicus merged commit 0323519 into development Dec 23, 2021
@abaicus abaicus deleted the feat/checkout-locked-layout branch December 23, 2021 10:36
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants