Fixes#219
Merged
Merged
Conversation
andylizi
reviewed
Jun 10, 2020
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <configuration> | ||
| <source>8</source> | ||
| <target>8</target> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Collaborator
Author
There was a problem hiding this comment.
Does not matter actually.
Col-E
reviewed
Jun 10, 2020
|
|
||
| @Override | ||
| public void stop() throws Exception { | ||
| controller.exit(); |
Owner
There was a problem hiding this comment.
When I set a breakpoint here, it never gets triggered.
The shutdown hooks get called correctly though, which is good.
Collaborator
Author
There was a problem hiding this comment.
For some reason ToolKit thinks that exit is called on non-jfx thread, gonna see why.
Owner
|
Gonna merge real quick since some of these are kinda important, like the filter being wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's fixed
Shutdown hooks does not run. (Causing first time launch stage show up repeatedly)
Wrong file extension suggestions.
Disable saving without loaded workspace
And for some reason, e.g. my installation of IDEA does not pickup source and target,so I also added a few changes to pom.xml