N°8763 Halt setup if non-uninstallable extension is missing #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odain-cbd
reviewed
Nov 27, 2025
odain-cbd
reviewed
Nov 27, 2025
setup/extensionsmap.class.inc.php
Outdated
| * @return NULL|iTopExtension | ||
| */ | ||
| public function IsExtensionObsoletedByAnother(iTopExtension $oExtension) | ||
| public function GetInstalledExtensionsFromDatabase(Config $oConfig): array|false |
Contributor
There was a problem hiding this comment.
in case of mysql xception, maybe it could be nice to log it.
odain-cbd
reviewed
Nov 27, 2025
odain-cbd
reviewed
Nov 27, 2025
odain-cbd
reviewed
Nov 27, 2025
odain-cbd
reviewed
Nov 27, 2025
odain-cbd
requested changes
Nov 27, 2025
rquetiez
requested changes
Nov 27, 2025
92e13b5 to
c25adf7
Compare
odain-cbd
reviewed
Dec 2, 2025
odain-cbd
reviewed
Dec 2, 2025
odain-cbd
reviewed
Dec 2, 2025
odain-cbd
reviewed
Dec 2, 2025
odain-cbd
requested changes
Dec 2, 2025
Contributor
odain-cbd
left a comment
There was a problem hiding this comment.
dont forget some unit test on your extension map changes. at least
odain-cbd
reviewed
Dec 2, 2025
odain-cbd
pushed a commit
that referenced
this pull request
Dec 4, 2025
* N°8763 Halt setup if an installed & non-uninstallable extension is missing from disk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.