Feature/virtual iFaces#20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables jumbo frames (MTU of 9000) to Ravel.
Ravel previously added routes to a single local interface to advertise them. In the past, attempts were made to increase MTU on this interface to 9000. However, this eventually led to packet loss in production environments when the segment length of the incoming packet differed with the MTUs on local pods.
This led to the approach in this PR that leverages virtual interfaces. In this approach, there is a 1:1 parity between virtual interfaces and ip addresses for both IPV4 and IPV6. In this way, we can tune each interface to a desired MTU for incoming traffic. Ravel consumes the
mtuandmtu6fields of the configmap to determine what MTU to set on a local interface, if not 1500.To implement this in a given environment, the pod interface must be set to 1500 as well. Within Comcast, this is implemented via a Kubernetes CNI plugin.
This MTU change does not affect the legacy ARP director mode. Jumbo frames will not be enabled there at the time of this change.