SPO-10: transaction verification for sponsored transactions #1469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 20, 2025 16:55
the signature verifiaction for sponsored transactions is different from the signature verifaction of normal transactions.
drsk0
commented
Nov 20, 2025
drsk0
commented
Nov 20, 2025
concordium-consensus/tests/consensus/ConcordiumTests/KonsensusV1/TransactionProcessingTest.hs
Show resolved
Hide resolved
td202
requested changes
Nov 21, 2025
Contributor
td202
left a comment
There was a problem hiding this comment.
Looks great! Just a couple of small things.
concordium-consensus/tests/consensus/ConcordiumTests/KonsensusV1/TransactionProcessingTest.hs
Show resolved
Hide resolved
concordium-consensus/tests/consensus/ConcordiumTests/KonsensusV1/TransactionProcessingTest.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/tests/consensus/ConcordiumTests/KonsensusV1/TransactionProcessingTest.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/tests/consensus/ConcordiumTests/KonsensusV1/TransactionProcessingTest.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/tests/consensus/ConcordiumTests/KonsensusV1/TransactionProcessingTest.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/tests/consensus/ConcordiumTests/KonsensusV1/TransactionProcessingTest.hs
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Dinsdale-Young <td202@users.noreply.github.com>
…V1/TransactionProcessingTest.hs Co-authored-by: Thomas Dinsdale-Young <td202@users.noreply.github.com>
Co-authored-by: Thomas Dinsdale-Young <td202@users.noreply.github.com>
|
The file size of the WebAssembly PLT deployment unit is 277268B. |
Co-authored-by: Thomas Dinsdale-Young <td202@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/sponsored-transactions #1469 +/- ##
===============================================================
Coverage 23.19% 23.20%
===============================================================
Files 34 34
Lines 10990 10990
===============================================================
+ Hits 2549 2550 +1
+ Misses 8441 8440 -1 |
added 6 commits
November 24, 2025 15:56
407fc45 to
1ed0ae9
Compare
ea1ef02 to
7dedb89
Compare
td202
approved these changes
Nov 25, 2025
concordium-consensus/tests/consensus/ConcordiumTests/KonsensusV1/TransactionProcessingTest.hs
Show resolved
Hide resolved
added 2 commits
November 25, 2025 11:22
bece2c8 to
24e0260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the transaction verification for extended transactions (including sponsored transactions).
Changes:
verifyExtendedTransactionimplementation