feat(new tool): add wifi qr code generator #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@CorentinTh Do you think that I should have integrated the tool into the existing QR Code generator ? I was mostly afraid that it would clutter the code of the component, especially of the template (I'm not very proficient in Vue.js sorry, it's my first time using the framework) |
CorentinTh
requested changes
Sep 4, 2023
There was a problem hiding this comment.
Hi @sbordeyne 👋🏻
Thank you for this PR, it's a good idea to not mix them and have unitary tools
Just few changes
Co-authored-by: Corentin THOMASSET <corentin.thomasset74@gmail.com>
Co-authored-by: Corentin THOMASSET <corentin.thomasset74@gmail.com>
CorentinTh
reviewed
Sep 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #576
closes #410
closes #549