fix(base64-file-converter): fix downloading of index.html content without data preambula #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…hout data preambula
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi @halex2005 ! Thank you for finding this bug and the PR to fix it ! I cannot push on your PR due to the fork, so I opened #750 from your to keep you commit in contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for great utilities site.
I have found that base64-file-converter tool doesn't work properly.
The downloaded file has content of site's
index.htmlif I've paste base64 string without preifx likedata:plain/text;base64,.This PR fixes that behavior by adding
data:plain/text;base64,to base64 string ifdata:not found in the input string.Please, consider to review and merge this PR.
Reproducing
Example of plain base64 string for testing:
With this input, in main branch, click on "Download file" button will download HTML of site. In PR branch it will download correct byte representation of base64 content.