Skip to content

fix(Token Generator): multi token, last settings, length input, denied chars #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

fix(Token Generator): multi token, last settings, length input, denied chars #913

wants to merge 13 commits into from

Conversation

@sharevb
Copy link
Contributor

@sharevb sharevb commented Mar 3, 2024 •
edited
Loading

@vercel
Copy link

vercel bot commented Mar 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
it-tools ✅ Ready (Inspect) Visit Preview Sep 22, 2024 5:05pm

@sharevb sharevb force-pushed the fix/token-generator branch from 42d5cc7 to 021368f Compare March 3, 2024 10:24
@sharevb sharevb mentioned this pull request Apr 3, 2024
Open
This was referenced Apr 29, 2024
Open
Open
Open
@sharevb sharevb mentioned this pull request May 11, 2024
Open
3 tasks
@sharevb sharevb force-pushed the fix/token-generator branch from 021368f to b97d2dd Compare May 13, 2024 06:27
@sharevb sharevb force-pushed the fix/token-generator branch from b97d2dd to ff57fda Compare May 13, 2024 06:30
@sharevb sharevb mentioned this pull request May 15, 2024
Open
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sharevb sharevb mentioned this pull request Jul 25, 2024
Closed
3 tasks
lemon8866 added a commit to lemon8866/it-tools that referenced this pull request Jul 26, 2024
@lemon8866
merge it-tools pr CorentinTh#913
61f2f20 
PR Author By@sharevb
@sharevb sharevb mentioned this pull request Aug 3, 2024
Open
3 tasks
@sharevb sharevb force-pushed the fix/token-generator branch from 896a9bb to 8881f44 Compare August 3, 2024 12:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sharevb sharevb changed the title fix(Token Generator): multi token, last settings, length input fix(Token Generator): multi token, last settings, length input, denied chars Aug 3, 2024
This was referenced Aug 23, 2024
Open
Open
Open
@sharevb
Copy link
Contributor Author

sharevb commented Sep 21, 2024

Hi @steffenrapp, may be interested in reviewing this one :) ?

@steffenrapp
Copy link
Contributor

steffenrapp commented Sep 21, 2024

Hi @sharevb I tested it and it works fine. Also looks good on mobile - also better than the current version.
The only problem is that you can enter 0 and negative values in both the length and the number of tokens. I think the minimum should be 1 for both? Also, the tool crashes (disappears) when you enter negative length and positive number of tokens.
Bildschirmfoto 2024-09-21 um 15 05 28

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sharevb
Copy link
Contributor Author

sharevb commented Sep 22, 2024

Hi @sharevb I tested it and it works fine. Also looks good on mobile - also better than the current version. The only problem is that you can enter 0 and negative values in both the length and the number of tokens. I think the minimum should be 1 for both? Also, the tool crashes (disappears) when you enter negative length and positive number of tokens.

Hi @steffenrapp, should be ok now

@steffenrapp
Copy link
Contributor

steffenrapp commented Sep 22, 2024

Hi @sharevb awesome! Everything fine now from my perspective.

@sunnydanu sunnydanu mentioned this pull request Oct 29, 2024
Open
@sharevb
Copy link
Contributor Author

sharevb commented Nov 24, 2024

Hi, for people interested in up to date version of it-tools, I made kind of a fork here : https://github.com/sharevb/it-tools (https://sharevb-it-tools.vercel.app/ and docker images https://github.com/sharevb/it-tools/pkgs/container/it-tools)

@jicho
Copy link

jicho commented Jul 2, 2025

@CorentinTh Are there any plans to merge this change into the official version of IT-tools?

@sharevb
Copy link
Contributor Author

sharevb commented Jul 2, 2025

Hi @jicho , I dont think really so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TOOL IMPROVEMENT] Token Generator to generate multiple tokens/passwords

3 participants

@sharevb @steffenrapp @jicho