feat(ipv4-range-expander): expands a given IPv4 start and end address to a valid IPv4 subnet #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to a valid IPv4 subnet
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CorentinTh
requested changes
Apr 19, 2023
|
|
||
| <script setup lang="ts"> | ||
| import SpanCopyable from '@/components/SpanCopyable.vue'; | ||
| import { paramCase } from 'change-case'; |
There was a problem hiding this comment.
[nit]
I'd prefer using _.kebabCase from lodash
They are more chance that I replace change-case than lodash 😅
Comment on lines
3
to
9
| class Ipv4RangeExpanderResult { | ||
| oldSize?: number; | ||
| newStart?: string; | ||
| newEnd?: string; | ||
| newCidr?: string; | ||
| newSize?: number; | ||
| } |
There was a problem hiding this comment.
I not fan of mixing paradigms, can you create a type (in a .type.ts file) instead of classe 🙏🏻
Comment on lines
+1
to
+32
| import { test, expect } from '@playwright/test'; | ||
|
|
||
| test.describe('Tool - IPv4 range expander', () => { | ||
| test.beforeEach(async ({ page }) => { | ||
| await page.goto('/ipv4-range-expander'); | ||
| }); | ||
|
|
||
| test('Has correct title', async ({ page }) => { | ||
| await expect(page).toHaveTitle('IPv4 range expander - IT Tools'); | ||
| }); | ||
|
|
||
| test('Calculates correct for valid input', async ({ page }) => { | ||
| await page.getByPlaceholder('Start IPv4 address...').fill('192.168.1.1'); | ||
| await page.getByPlaceholder('End IPv4 address...').fill('192.168.7.255'); | ||
|
|
||
| expect(await page.getByTestId('start-address.old').textContent()).toEqual('192.168.1.1'); | ||
| expect(await page.getByTestId('start-address.new').textContent()).toEqual('192.168.0.0'); | ||
| expect(await page.getByTestId('end-address.old').textContent()).toEqual('192.168.7.255'); | ||
| expect(await page.getByTestId('end-address.new').textContent()).toEqual('192.168.7.255'); | ||
| expect(await page.getByTestId('addresses-in-range.old').textContent()).toEqual('1,791'); | ||
| expect(await page.getByTestId('addresses-in-range.new').textContent()).toEqual('2,048'); | ||
| expect(await page.getByTestId('cidr.old').textContent()).toEqual(''); | ||
| expect(await page.getByTestId('cidr.new').textContent()).toEqual('192.168.0.0/21'); | ||
| }); | ||
|
|
||
| test('Hides result for invalid input', async ({ page }) => { | ||
| await page.getByPlaceholder('Start IPv4 address...').fill('192.168.1.1'); | ||
| await page.getByPlaceholder('End IPv4 address...').fill('192.168.0.255'); | ||
|
|
||
| await expect(page.getByTestId('result')).not.toBeVisible(); | ||
| }); | ||
| }); |
| </n-form-item> | ||
| </n-space> | ||
|
|
||
| <n-table v-if="showResult" data-test-id="result"> |
There was a problem hiding this comment.
add a feedback when ip are valid but their is no result since range is invalid please
Comment on lines
75
to
89
| const showResult = computed( | ||
| () => | ||
| validationAttrsStart.validationStatus !== 'error' && | ||
| validationAttrsEnd.validationStatus !== 'error' && | ||
| result.value !== undefined, | ||
| ); | ||
| const { attrs: validationAttrsStart } = useValidation({ | ||
| source: rawStartAddress, | ||
| rules: [{ message: 'Invalid ipv4 address', validator: (ip) => isValidIpv4({ ip }) }], | ||
| }); | ||
|
|
||
| const { attrs: validationAttrsEnd } = useValidation({ | ||
| source: rawEndAddress, | ||
| rules: [{ message: 'Invalid ipv4 address', validator: (ip) => isValidIpv4({ ip }) }], | ||
| }); |
There was a problem hiding this comment.
Suggested change
| const showResult = computed( | |
| () => | |
| validationAttrsStart.validationStatus !== 'error' && | |
| validationAttrsEnd.validationStatus !== 'error' && | |
| result.value !== undefined, | |
| ); | |
| const { attrs: validationAttrsStart } = useValidation({ | |
| source: rawStartAddress, | |
| rules: [{ message: 'Invalid ipv4 address', validator: (ip) => isValidIpv4({ ip }) }], | |
| }); | |
| const { attrs: validationAttrsEnd } = useValidation({ | |
| source: rawEndAddress, | |
| rules: [{ message: 'Invalid ipv4 address', validator: (ip) => isValidIpv4({ ip }) }], | |
| }); | |
| const showResult = computed( | |
| () => | |
| endIpValidation.isValid && | |
| startIpValidation.isValid && | |
| result.value !== undefined, | |
| ); | |
| const startIpValidation = useValidation({ | |
| source: rawStartAddress, | |
| rules: [{ message: 'Invalid ipv4 address', validator: (ip) => isValidIpv4({ ip }) }], | |
| }); | |
| const endIpValidation = useValidation({ | |
| source: rawEndAddress, | |
| rules: [{ message: 'Invalid ipv4 address', validator: (ip) => isValidIpv4({ ip }) }], | |
| }); |
And bind endIpValidation.attrs
* main: feat(date converter): auto focus main input
|
Kudos, SonarCloud Quality Gate passed!
|
CorentinTh
approved these changes
Apr 19, 2023
|
Thank you for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #279