Default pod/container securityContext: read-only root FS + no privilege escalation (fixes #188) #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tightens Calrissian’s default container security context as requested in #188
Specifically:
readOnlyRootFilesystem: true by default for all step containers, with defaultcwltoolflag--no-read-onlyto restore a writable root if neededallowPrivilegeEscalation: false set explicitly on all step containersprivileged: false set explicitly on all step containers (This is already the normal default in Kubernetes, but we now declare it for clarity)Tests
Unit tests verifying:
Default container securityContext includes
readOnlyRootFilesystem: true,allowPrivilegeEscalation: false,privileged: false--no-read-onlyflips onlyreadOnlyRootFilesystemto falseBackwards compatibility
Workflows that rely on a writable root filesystem can pass
--no-read-onlyNo change to existing
--no-match-userbehavior