🐛 Fix selection of syllable after edit modal.#853
Merged
Conversation
♻️ Remove console log and extract variable. 🐛 Fix empty bbox selected. 🐛 Fix keyboard shortcuts not working after hiding modal (w/ David).
yinanazhou
requested changes
May 31, 2022
yinanazhou
left a comment
Member
There was a problem hiding this comment.
I noticed that when one bbox is selected, if the user clicks on the text to select another bbox, the previous bbox is selected instead of the new one in the background. As shown in the figure below, I was editing the text for sur, but lem is selected. Is there a way to fix this?
Also, could you please delete the console.log() in ModalWindow.ts?
yinanazhou
approved these changes
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #830 .
♻️ Remove console log and extract variable.
🐛 Fix empty bbox selected.
🐛 Fix keyboard shortcuts not working after hiding modal (w/ David).