Refactor fan control service and documentation#2
Merged
Conversation
Replace the single-purpose fan scripts with a validated controller that supports auto, once, manual, restore, status, and validate commands. Add fail-safe fan speed handling, hysteresis, ESXi/iDRAC/GPU temperature sources, dry-run support, and shell tests for the core decision logic.
Remove tracked environment files, add ignore rules, and refresh the example configuration for the new controller. Update Docker, Compose, and GHCR publishing workflow so builds validate the entrypoint and CI checks the Compose configuration.
Replace the stale README with a complete guide for safe operation, configuration, testing, and troubleshooting. Convert the usage guide into a short day-to-day runbook and move the iDRAC screenshot into a correctly named images directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
make testmake validatedocker compose configdocker build --build-arg BASE_IMAGE=ubuntu:24.04 -t idrac-fan-control:test .docker build -t idrac-fan-control:cuda-test .docker run --rm -e DRY_RUN=true -e OPERATION_MODE=auto -e TEMPERATURE_SOURCES=idrac -e IDRAC_IP=192.0.2.10 -e IDRAC_ID=root -e IDRAC_PASSWORD=test idrac-fan-control:cuda-test validatedocker run --rm -e DRY_RUN=true -e IDRAC_IP=192.0.2.10 -e IDRAC_ID=root -e IDRAC_PASSWORD=test idrac-fan-control:cuda-test manual 35Notes
.envis removed from Git tracking but preserved locally and ignored by.gitignore.DRY_RUN=true.