Add working example of environment based time zones#73
Merged
Conversation
Collaborator
Author
Collaborator
Author
|
How to view timezones In [40]: import pytz |
67b4c5c to
9861dac
Compare
emmuhamm
commented
Jun 4, 2026
Collaborator
Author
|
@PawelPlesniak review pls :) When this is all good and merged, I'll let kurt know about this |
PawelPlesniak
left a comment
Collaborator
There was a problem hiding this comment.
Small comment, but other than that, nice work!
Collaborator
Author
|
I dont see any major comments here and I've fixed the minor comment, so I'll take this as an approval! Will merge as soon as the tests pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #70
Add better timezone handling. This is going to be optionally done by an environment variable, which overrides the log_format.ini settings.
Add better theme handling. This is also going to optionally done by an environment variable, which overrides the log_format.ini settings.
For full explanations, please see the docs in this PR, and also the testing notes
Testing notes
Tested on latest nightly (doesnt matter which)
Run
export DUNEDAQ_TIMEZONE="Europe/London"export DUNEDAQ_LOGGING_THEME="dark"and
daqpytools-logging-demonstrator -rSee how the colors and the timezones has changed. Play around with various timezones and themes.
When finish, run
export DUNEDAQ_TIMEZONE=""export DUNEDAQ_LOGGING_THEME=""And see how they revert back to their default behaviour
TODO:
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))