Skip to content

JCF: DUNE-DAQ/daq-deliverables#215: update the code to account for me…#42

Closed
jcfreeman2 wants to merge 1 commit into
developfrom
johnfreeman/daq-deliverables_issue215_fddetdataformats_improvements
Closed

JCF: DUNE-DAQ/daq-deliverables#215: update the code to account for me…#42
jcfreeman2 wants to merge 1 commit into
developfrom
johnfreeman/daq-deliverables_issue215_fddetdataformats_improvements

Conversation

@jcfreeman2

@jcfreeman2 jcfreeman2 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

…mber data being defaulted to private on the johnfreeman/daq-deliverables_issue215_fddetdataformats_improvements branch of fddetdataformats

Description

This is a very simple one line change, but one which is only to be merged after the merging of fddetdataformats' DUNE-DAQ/fddetdataformats#58 PR. It updates the code to reflect the fact that member data in frames is made private in that PR.

Testing would essentially be, does the code build? It should be done in concert with the testing of the other repos which have branches with the johnfreeman/daq-deliverables_issue215_fddetdataformats_improvements name (fddetdataformats, obviously, but also crtmodules and fdreadoutlibs).

Type of change

This is a bug fix in the sense that, once the fddetdataformats PR is merged in, the code on the develop branch of this repo will be broken until this PR is merged in.

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

…mber data being defaulted to private on the johnfreeman/daq-deliverables_issue215_fddetdataformats_improvements branch of fddetdataformats
@jcfreeman2 jcfreeman2 closed this Jun 10, 2026
@jcfreeman2 jcfreeman2 deleted the johnfreeman/daq-deliverables_issue215_fddetdataformats_improvements branch June 10, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants