JCF: DUNE-DAQ/daq-deliverables#215: update the code to account for me…#42
Closed
jcfreeman2 wants to merge 1 commit into
Closed
Conversation
…mber data being defaulted to private on the johnfreeman/daq-deliverables_issue215_fddetdataformats_improvements branch of fddetdataformats
Open
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mber data being defaulted to private on the johnfreeman/daq-deliverables_issue215_fddetdataformats_improvements branch of fddetdataformats
Description
This is a very simple one line change, but one which is only to be merged after the merging of
fddetdataformats' DUNE-DAQ/fddetdataformats#58 PR. It updates the code to reflect the fact that member data in frames is madeprivatein that PR.Testing would essentially be, does the code build? It should be done in concert with the testing of the other repos which have branches with the
johnfreeman/daq-deliverables_issue215_fddetdataformats_improvementsname (fddetdataformats, obviously, but alsocrtmodulesandfdreadoutlibs).Type of change
This is a bug fix in the sense that, once the
fddetdataformatsPR is merged in, the code on thedevelopbranch of this repo will be broken until this PR is merged in.Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))