Skip to content

Improve error handling in typosquatting module#606

Merged
sobregosodd merged 18 commits into
DataDog:mainfrom
strongHunter:strongHunter/typosquatting-error-handling
Nov 2, 2025
Merged

Improve error handling in typosquatting module#606
sobregosodd merged 18 commits into
DataDog:mainfrom
strongHunter:strongHunter/typosquatting-error-handling

Conversation

@strongHunter
Copy link
Copy Markdown

Network errors are now handled and logged. If fetching from the internet fails, the local file is used. Minor code refactoring was performed. The module is now always returns data.

Previously, if the local file was outdated, the module would attempt to fetch it from the network. If a network error occurred, this would cause to fail.

@sobregosodd
Copy link
Copy Markdown
Contributor

sobregosodd commented Oct 9, 2025

Hello @strongHunter , thanks for the contribution,
I've realized that some checks are not passing, mostly because the linting errors and typing errors, since functions don't always return the same value type (depending on the raise).
Let me know if you can address them.

tip: there is a Makefile that helps with this checks, ie: make lint; make type-check; make format

@strongHunter
Copy link
Copy Markdown
Author

Fixed. Check out

@sobregosodd
Copy link
Copy Markdown
Contributor

Thanks for the contrib!

@sobregosodd sobregosodd merged commit 3ebb506 into DataDog:main Nov 2, 2025
11 checks passed
christophetd pushed a commit that referenced this pull request Apr 10, 2026
…error-handling

Improve error handling in typosquatting module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants