fix(node) appsec and capabilities tests#8020
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8020 +/- ##
=======================================
Coverage 73.59% 73.60%
=======================================
Files 773 773
Lines 36083 36084 +1
=======================================
+ Hits 26557 26558 +1
Misses 9526 9526 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overall package sizeSelf size: 5.5 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: c91aa27 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
BenchmarksBenchmark execution time: 2026-04-16 22:38:35 Comparing candidate commit c91aa27 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1374 metrics, 110 unstable metrics. |
BridgeAR
left a comment
There was a problem hiding this comment.
Thank you for the quick fixes!
* fix capabilities tests * call destroy with setImmediate
* fix capabilities tests * call destroy with setImmediate
What does this PR do?
This PR fixes tests failing after node 24.15.0 were released.
Capabilities tests are failing as consequence of ( nodejs/node#62030 ) which changed the way path defaults to '/' when not specified.
AppSec tests started failing as consequence of ( https://github.com/node/pull/61770 ) this change moved the registration of socket error listeners to an earlier step in the lifecycle. Combined with the test pattern of creating and rapidly destroying request, those listeners piled up on the same reused agent socket, excedding our low defaultMaxListeners threshold of 6.
Motivation
Additional Notes