chore(codeowners): own remaining benchmark dirs and enforce in CI#8204
Conversation
…verage in CI 17 bench dirs under `benchmark/sirun/` and the helpers in `benchmark/stubs/` had no CODEOWNERS rule on master, so changes routed to no team. The `lint:codeowners:ci` glob expands to cover `benchmark/sirun/**` so future bench dirs without an entry fail CI. Drive-by fix: * `/benchmark/sirun/debugger` gets the trailing slash GitHub needs to match the directory only.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e21c9b479
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
BenchmarksBenchmark execution time: 2026-05-01 18:03:53 Comparing candidate commit 13585c8 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1743 metrics, 101 unstable metrics. |
rochdev
left a comment
There was a problem hiding this comment.
Some of those should arguably belong to SDK, but we can always readjust.
Overall package sizeSelf size: 5.68 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
) 17 bench dirs under `benchmark/sirun/` and the helpers in `benchmark/stubs/` had no CODEOWNERS rule on master, so changes routed to no team. The `lint:codeowners:ci` glob expands to cover `benchmark/sirun/**` so future bench dirs without an entry fail CI. Drive-by fix: * `/benchmark/sirun/debugger` gets the trailing slash GitHub needs to match the directory only.
17 bench dirs under
benchmark/sirun/and the helpers inbenchmark/stubs/had no CODEOWNERS rule on master, so changes routed to no team. Thelint:codeowners:ciglob expands to coverbenchmark/sirun/**so future bench dirs without an entry fail CI.Drive-by fix:
/benchmark/sirun/debuggergets the trailing slash GitHub needs to match the directory only.This depends on the benchmark PRs to land first.