Skip to content

Conversation

@nowsprinting
Copy link
Contributor

Changes

  • Add command line argument -FILE_LOGGER_OUTPUT_PATH. Overwrite the outputPath of FileLogger
  • Fix READMEs for SlackReporter
  • Fix case of outputPath without directory
  • Fix case of outputPath is not set

Priority

It's a low priority for me.


Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner June 5, 2024 23:33
@github-actions github-actions bot added the fix label Jun 5, 2024
Copy link
Contributor

@Kuniwak Kuniwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kuniwak Kuniwak merged commit 3ee1bee into DeNA:master Jun 6, 2024
@Kuniwak Kuniwak added the feature label Jun 6, 2024
@nowsprinting nowsprinting deleted the fix/filelogger branch June 6, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants