Skip to content

Conversation

@nowsprinting
Copy link
Contributor

Changes

  • Add ErrorHandlerAgent migrated from LogMessageHandler
    • Error handling settings can be reused across multiple AutopilotSettings
    • Selectable log handling behavior (Add "Reporting Only")
  • Obsolete error handling setting fields in AutopilotSettings
  • Fix to Agents termination
    • Terminate autopilot by the Agent is no longer dependent on ErrorHandlerAgent
    • Use Exceptions instead of UnityEngine.Assertions
    • Organize exit code

Priority

I hope to your review && merge around one week.
There is no need to release it yet.


Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner November 10, 2024 00:14
Copy link
Contributor

@asurato asurato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asurato asurato merged commit 9c26535 into DeNA:master Nov 11, 2024
3 checks passed
@asurato
Copy link
Contributor

asurato commented Nov 11, 2024

@nowsprinting
Thank you for your contribution!

@nowsprinting nowsprinting deleted the feature/error_handler_agent branch November 11, 2024 10:18
@nowsprinting nowsprinting mentioned this pull request Nov 16, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants