chore: Remove expression namespaces #5619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5619 +/- ##
==========================================
+ Coverage 69.27% 70.30% +1.03%
==========================================
Files 1020 1021 +1
Lines 133235 131144 -2091
==========================================
- Hits 92294 92198 -96
+ Misses 40941 38946 -1995
🚀 New features to boost your workflow:
|
Contributor
|
Skipped: This PR changes more files than the configured file change limit: ( |
kevinzwang
approved these changes
Nov 24, 2025
Member
kevinzwang
left a comment
There was a problem hiding this comment.
Beautiful. One more place where we use the deprecated expressions is in the examples on the daft.ai homepage. Just make sure to change those too before we release!
Collaborator
Author
I'll make a ticket! |
ykdojo
added a commit
that referenced
this pull request
Dec 2, 2025
The `.dt` namespace was removed in #5619. Update the property-based test to call `.year()` directly on the expression instead of `.dt.year()`.
2 tasks
colin-ho
pushed a commit
that referenced
this pull request
Dec 2, 2025
## Summary Fixes the nightly property-based test failure: https://github.com/Eventual-Inc/Daft/actions/runs/19835912383 The `.dt` namespace on `Expression` was removed in #5619. This updates the property-based test to call `.year()` directly on the expression instead of `.dt.year()`. ## Test plan - [x] Verified test fails before fix - [x] Verified test passes after fix with 1000 examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Bye bye
Related Issues
Checklist
docs/mkdocs.ymlnavigation