4001 vendor mimemagic to deal with license issues #4002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8e1ffb to
a390579
Compare
Contributor
|
@mnyon-grandkru merge conflicts |
c1f9bfb to
1086d47
Compare
rlgreen91
reviewed
Apr 6, 2021
Contributor
rlgreen91
left a comment
There was a problem hiding this comment.
I really just have the one question about the change to the acts_as_follower gem
Gemfile
Outdated
|
|
||
| # follower functionality | ||
| gem 'acts_as_follower', github: 'tcocca/acts_as_follower' | ||
| gem 'acts_as_follower' |
Contributor
There was a problem hiding this comment.
I believe the version listed on Rubygems has an issue with Rails 5+, which is why we switched to using the source here
Contributor
Author
There was a problem hiding this comment.
Got it. Restoring github
6d5846f to
8ed607f
Compare
rlgreen91
approved these changes
Apr 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In your PR did you: