@rachaelkiteme can you add a spec to make sure that if an agency is created with a random jurisidiction type that's not listed, that it gets flagged as invalid?

@rachaelkiteme No worries. So what I mean is that I want you to add a test where, if we try to create an agency with some random jurisdiction listed, like carrot, then it will be flagged as invalid and won't save. If you write the test and it fails, meaning that it does save correctly, then you'll need to update the agency model to make sure it doesn't.

If you look at the test ensuring that an agency has a name, that should provide you with a good example. If you do need to update the agency model, then I would check out the enumerated_type gem - they should have a method to get all of the enums of a model without having to hardcode them.

Hey, so this looks good, but what I was looking for was kind of the opposite - that if you tried to create an agency with an invalid jurisdiction type, that it would fail. Can you change that? Also, can you add a feature spec that does the same thing? We might as well go ahead and add it now.

Also, I'll check Travis and see what's going on. So it's saying that the agency factory is already registered - I see that you merged master into your branch. Did you run bundle update to get any gem changes? That might be it.

Hey! So, three quick notes: first, I figured out why Travis is complaining - we have two agency factories. You have both a spec/factories/agencies.rb and a spec/factory/agency.rb. They seem identical to me, so just delete one of them, doesn't matter which. Second, having a jurisdiction type isn't required for an agency to be valid - we just need to make sure that if the user enters one it's a valid type. You can keep the tests for it having a valid jurisdiction type, just get rid of the ones that require it to have a jurisdiction type to be a valid object. Third, these are enumerables, so rather than list each jurisdiction type like %w [none, local, state, federal, university] you can just use JurisdictionType.entries.

Anyways, that factory change should get Travis to work. Let me know if it doesn't.

You can keep the validation, just set it so that it can be nil - https://stackoverflow.com/questions/5924582/is-there-a-shortcut-for-validating-a-field-only-when-its-present-in-rails-3

Hello, once I try assigning jurisdiction_type: 'local' I get error Jurisdiction type is not included in the list then I inspected JurisdictionType.entries the results are as in the screenshot what could be the problem? please help

Had to use %w(none state local federal university private) so that jurisdiction type can be read as listed

Huh, that's weird. Not sure why that wouldn't work, given that's what the gem's author says to do.

Anyways, in app/models/case.rb, allow_nil should be after the inclusion hash - right now it looks like it's inside it.

You can also get rid of the changes you made to the test 'is invalid without a state' and get rid of the test on lines 46-49.

That's pretty much it; I'll merge whenever those changes are made. Thanks for tackling this. Some of this is wrangling with tests in the hopes that it'll be easier later on.

Yeah, thanks for sticking with this. Testing is tricky - it really takes some time to grok how testing should go. I think our repo is a bit misleading, because it says we have a really high test coverage, but when you actually look at the tests themselves there's a bunch of stuff we don't account for. Case in point - I'm going to assign you to an issue because I forgot a step in this whole process, and better testing would have caught it.