Create CaseMailer #3200 #3251
Merged
Create CaseMailer #3200 #3251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@StlMaris123 have you run |
Collaborator
Author
|
Hi @trystant , yes I did...It is a refactoring issue on the case mailer |
Contributor
|
Heyo, so I would like to hold this PR - someone else is working on renaming this mailer from |
Contributor
|
@StlMaris123 can you resolve these merge conflicts? Then I'll be able to merge this. |
…iler # Conflicts: # app/controllers/cases_controller.rb # app/mailers/user_notifier.rb # app/views/case_mailer/send_deletion_email.html.erb # app/views/case_mailer/send_followers_email.html.erb # app/views/user_mailer/send_deletion_email.html.erb # app/views/user_mailer/send_followers_email.html.erb # app/views/user_notifier/send_deletion_email.html.erb # app/views/user_notifier/send_followers_email.html.erb # spec/mailers/previews/user_notifier_preview.rb # spec/mailers/user_mailer_spec.rb
rlgreen91
requested changes
Oct 18, 2019
| @@ -0,0 +1,28 @@ | |||
| # frozen_string_literal: true | |||
Contributor
There was a problem hiding this comment.
Please use keyword arguments.
Contributor
|
Hey @StlMaris123 are you going to be able to finish this soon? |
Contributor
|
@StlMaris123 one last thing - can you take care of the CodeClimate failures? You can ignore the ones about similar blocks of code, but fix the line too long and missing top-level documentation one. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In your PR did you: