Skip to content

view: moves get newsletter button to navbar for better visibility #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rlgreen91 merged 1 commit into from
Oct 15, 2019
Merged

view: moves get newsletter button to navbar for better visibility #3374

rlgreen91 merged 1 commit into from
Oct 15, 2019

Conversation

@carloslazo
Copy link
Collaborator

@carloslazo carloslazo commented Oct 12, 2019 •
edited
Loading

Adresses #2407

Screen Shot 2019-10-12 at 1 44 03 AM

Screen Shot 2019-10-12 at 1 49 23 AM

In your PR did you:

  • Include a description of the changes?
  • Mention the issue the PR addresses?
  • Include screenshots of any changes to the UI?
  • Isolate any changes to gems (meaning that any new, updated, or removed gems and resulting code changes should be in their own PR)?
  • Add and/or update specs for your code?

@carloslazo
Copy link
Collaborator Author

carloslazo commented Oct 12, 2019

Let me know if you want me to do more UI contributions. Maybe mobile responsive features that seem to needed.

@carloslazo carloslazo force-pushed the moves-get-newsletter-button branch from 7d5b458 to 71c408a Compare October 14, 2019 21:28
@carloslazo carloslazo requested a review from rlgreen91 October 14, 2019 21:33
rlgreen91
rlgreen91 approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@rlgreen91 rlgreen91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlgreen91 rlgreen91 merged commit 745ebf8 into master Oct 15, 2019
@rlgreen91 rlgreen91 deleted the moves-get-newsletter-button branch October 15, 2019 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rlgreen91 rlgreen91 rlgreen91 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carloslazo @rlgreen91