History page user link (Issue #782) #3428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I believe the error thrown on the Travis check is unrelated to my change.
|
Contributor
|
I'm not sure why Github...refuses to update this branch with master? I'll do it myself, Thanos-style |
Contributor
|
Hi @daniellecroxton, thank you for your contribution. You're right about Travis - it has an issue with PR builds initiated from forks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regards to issue Add link to user in history tab #782, replaced
<%= user.name %>with<%= link_to user.name, user_path(user) %>to link user's name to corresponding user page.In your PR did you: