Added dev environment to those where Rollbar isn't called #3841 #3842
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockdeep
reviewed
Jan 31, 2021
config/initializers/rollbar.rb
Outdated
| # Here we'll disable in 'test': | ||
| config.enabled = false if Rails.env.test? | ||
| # Here we'll disable in 'test' and 'development': | ||
| config.enabled = false if Rails.env.test? or Rails.env.development? |
Contributor
There was a problem hiding this comment.
@trystant or has super weird operator precedence, so I'd generally go with || in situations like this. That being said, I tried a similar change before I saw this PR, but it sounds like we might want to discuss what approach to take with this.
Contributor
There was a problem hiding this comment.
@mockdeep Yeah, or is lower on the Ruby operator precedence totem pole. I'll change that up.
5 tasks
f4df22d to
d0f0f4d
Compare
rlgreen91
approved these changes
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In your PR did you: