CI: pull rspec workflow out of Docker image #3927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ba7d5a to
a795a4d
Compare
a795a4d to
fb53873
Compare
6b069ff to
fb53873
Compare
Collaborator
|
@mockdeep if you pull this one out of draft, I'm ready to move forward with it. |
managedkaos
reviewed
Feb 15, 2021
Collaborator
managedkaos
left a comment
There was a problem hiding this comment.
@mockdeep Any reason why the codeclimate workflow was removed? Just wondering...
Contributor
Author
|
@managedkaos codeclimate is already reporting from its own infrastructure, so it seemed redundant to also be running it on Github Actions. |
rlgreen91
reviewed
Feb 23, 2021
Contributor
rlgreen91
left a comment
There was a problem hiding this comment.
LGTM, @managedkaos just let me know when you approve it and I'll merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.