Skip to content

Do not vendor inih#479

Merged
carstene1ns merged 1 commit into
EasyRPG:masterfrom
Ghabry:inih-no-vendor
Apr 15, 2024
Merged

Do not vendor inih#479
carstene1ns merged 1 commit into
EasyRPG:masterfrom
Ghabry:inih-no-vendor

Conversation

@Ghabry

@Ghabry Ghabry commented Apr 14, 2024

Copy link
Copy Markdown
Member

The C++ part of the library is still kept as we made changes to it.

One patch less for Fedora ;)

@Ghabry Ghabry added this to the 0.8.1 milestone Apr 14, 2024
@Ghabry Ghabry requested a review from carstene1ns April 14, 2024 21:15
The C++ part of the library is still kept as we made changes to it.

@carstene1ns carstene1ns left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

Have installed inih-devel on server now to solve jenkins failure. EasyRPG/buildscripts#174
Let`s just hope the API does not change so our vendored part will not break.

@carstene1ns carstene1ns merged commit 54dff22 into EasyRPG:master Apr 15, 2024
@Ghabry Ghabry deleted the inih-no-vendor branch April 15, 2024 21:16
@Ghabry

Ghabry commented Apr 15, 2024

Copy link
Copy Markdown
Member Author

all green. only flatpak requires adding inih.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants