-
Notifications
You must be signed in to change notification settings - Fork 16
Song Select Preview Audio #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JaydenzKoci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i copy pasted most of the previous song select menu to work with song previews and sorting. It works great tho
|
i'll check it out when i get to my computer to dev |
|
nice lmk if there's anything else you need done or fixed |
|
please merge this already lmao. |
|
apologies for the delay, i'll be getting to it as soon as possible |
solamint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| if (!IsAudioDeviceReady()) { | ||
| InitAudioDevice(); | ||
| TraceLog(LOG_INFO, "Initialized audio device"); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is init using raylib audio. we don't use raylib audio here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also the audio device is already initialized on boot lol
| ); | ||
| } else if (!TheSongList.listMenuEntries[i].hiddenEntry) { | ||
| bool isCurSong = i == TheSongList.curSong->songListPos - 1; | ||
| bool isCurSong = TheSongList.curSong && i == TheSongList.curSong->songListPos - 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HOLY SHIT is this the fix for that crash that happens after reloading the song cache?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think? I forgot to comment on it lol
"was having a little merge problem before lmfao" A little bit of a wip. But should give a good gist of the update of it. Probably going for optimization later