Skip to content

Conversation

@JaydenzKoci
Copy link

"was having a little merge problem before lmfao" A little bit of a wip. But should give a good gist of the update of it. Probably going for optimization later

@JaydenzKoci JaydenzKoci changed the title song select menu revamp. Song Select Preview Audio. Sep 2, 2025
@JaydenzKoci JaydenzKoci changed the title Song Select Preview Audio. Song Select Preview Audio Sep 2, 2025
Copy link
Author

@JaydenzKoci JaydenzKoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i copy pasted most of the previous song select menu to work with song previews and sorting. It works great tho

@solamint
Copy link
Collaborator

solamint commented Sep 2, 2025

i'll check it out when i get to my computer to dev

@JaydenzKoci
Copy link
Author

nice lmk if there's anything else you need done or fixed

@JaydenzKoci
Copy link
Author

please merge this already lmao.

@solamint
Copy link
Collaborator

solamint commented Sep 5, 2025

apologies for the delay, i'll be getting to it as soon as possible

@solamint solamint self-requested a review September 5, 2025 06:14
Copy link
Collaborator

@solamint solamint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

if (!IsAudioDeviceReady()) {
InitAudioDevice();
TraceLog(LOG_INFO, "Initialized audio device");
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is init using raylib audio. we don't use raylib audio here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the audio device is already initialized on boot lol

);
} else if (!TheSongList.listMenuEntries[i].hiddenEntry) {
bool isCurSong = i == TheSongList.curSong->songListPos - 1;
bool isCurSong = TheSongList.curSong && i == TheSongList.curSong->songListPos - 1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HOLY SHIT is this the fix for that crash that happens after reloading the song cache?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think? I forgot to comment on it lol

@solamint solamint merged commit f7c4c12 into Encore-Developers:indev Sep 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants